Config updates

[lmakarov]

• Fixed virtual host config overrides
  • Load the standard (host.conf) config first and the override (httpd-vhost-overrides.conf) config last, so overrides actually take effect.
  • Added tests for Directory block configuration overrides
• Update SSL configuration to allow TLSv1.2 and TLSv1.3 protocols

Resolves #27

Summary by CodeRabbit

• New Features

  • Extended TLS/SSL protocol support to include TLSv1.3 alongside TLSv1.2, enabling stronger encryption for secure connections
  • Introduced configuration file override functionality for directory-level settings with refined include precedence ordering

• Tests

  • Added test coverage validating configuration override behavior and directory-level precedence handling across HTTP and HTTPS requests

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f302a340-f180-4d9c-8ff8-cf6db1509df6

📥 Commits

Reviewing files that changed from the base of the PR and between ffc7385 and e21a2d5.

📒 Files selected for processing (4)

• conf/extra/httpd-vhosts.conf
• tests/config-directory-override/httpd-vhost-overrides.conf
• tests/config/httpd-vhost-overrides.conf
• tests/test.bats

---

📝 Walkthrough

Walkthrough

This PR reorders Apache virtual host configuration includes to ensure custom overrides apply after the base host configuration, allowing override directives to take precedence. The HTTPS virtual host now accepts both TLSv1.2 and TLSv1.3. Tests confirm directory-level overrides work correctly with the new load order.

Changes

Apache Virtual Host Override Precedence

Layer / File(s)	Summary
Virtual host configuration reordering and TLS protocol updates conf/extra/httpd-vhosts.conf	The *:80 and *:443 virtual hosts now load IncludeOptional conf/custom/httpd-vhost-overrides.conf after Include conf/extra/includes/host.conf, reversing the previous order. HTTPS SSLProtocol and SSLProxyProtocol directives now allow both TLSv1.2 and TLSv1.3 instead of TLSv1.2-only, while cipher-suite restrictions remain unchanged.
Test configuration fixtures and override precedence verification tests/config-directory-override/httpd-vhost-overrides.conf, tests/config/httpd-vhost-overrides.conf, tests/test.bats	New test config files define <Directory> blocks with override directives (including explicit access denial and wrapped directory index). Bats test Configuration overrides - Directory block mounts the directory override config, verifies service health, and confirms HTTP and HTTPS both return 403 Forbidden, validating that directory-level overrides take effect over the base host configuration.

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Config updates' is vague and generic, lacking specificity about the primary changes made in the pull request.	Use a more descriptive title that highlights the main change, such as 'Fix virtual host config override precedence and update SSL protocols' or 'Allow httpd-vhost-overrides.conf to load last for proper precedence'.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	All coding requirements from issue #27 are met: virtual host config loading order fixed, override file loads last, and SSL protocol configuration updated to support TLSv1.2 and TLSv1.3.
Out of Scope Changes check	✅ Passed	All changes directly address issue #27: reordering config includes, updating SSL protocols, and adding corresponding tests. No out-of-scope changes detected.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/config-updates

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[lmakarov]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.