Feature/update port#268
Open
CarlSargunar wants to merge 5 commits intodocker:masterfrom
Open
Conversation
|
Hi, I did have the same problem and thought I'll have a look and create a PR. I found your issue. I think instead of changing the port to 9080 it should stay as it is. I think having access to BUT I think an explanation should be there, if an error is thrown on Windows, it is likely because IIS is using it already. ... IMO the explanation should be enough. just some thoughts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #267
This will set the default instructions which will allow windows users who are web developers, and therefore likely to be running IIS which uses port 80.
Added some additional info as to why these ports are used, but open to suggestions on how to word this.
Please note - I also had to make the changes suggested in #257 to get a local image to build locally, but I have not submitted those changes as part of this PR, since they are not related