fix: select player info data list field#3650
Merged
dmulloy2 merged 1 commit intoJul 11, 2026
Merged
Conversation
dmulloy2
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
getPlayerInfoDataLists()incorrectly including the player info actions field.ClientboundPlayerInfoUpdatePacketcontains anEnumSet<Action>for its actions and aList<Entry>for its player info entries. SincegetPlayerInfoDataLists()searched for everyCollectionfield, both fields were included in the returned modifier.This made index
0point to the actions field instead of the entries list. WritingPlayerInfoDatato the expected index could then fail with:Plugins had to use the undocumented index 1 as a workaround.
The method now uses the existing getLists() helper, so only actual List fields are selected and the player info entries are available at index 0 as expected.
Validated with ./gradlew.bat clean test assemble.
Fixes #2760
Related: #3215, #3361, #3303