Pin RoboTwin to the Hopper-safe CuRobo revision - #4
Open
gpulost wants to merge 1 commit into
Open
Conversation
Signed-off-by: liuke <liuke@dexmal.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpulost/curobo@3490ef46d4ffbbf6756b91fb13b68215828533b0;Motivation
RoboTwin currently clones the floating
NVlabs/curobodefault branch in itsbase installer, while two policy environment files pin an older CuRobo commit.
Those paths can install the original fused LBFGS reduction, whose synchronized
warp masks have undefined behavior on partial warps and can fail on Hopper.
The pinned commit contains the Hopper-safe LBFGS reduction proposed in
NVlabs/curobo#708. The overlay keeps the RoboTwin gitlink unchanged while
making all three known CuRobo installation paths deterministic.
Validation
git apply --checksucceeds against RoboTwindaef39a2f43226fb5af87552544e03d1f1bc70d9.patch --dry-run -d RoboTwin -p1succeeds, matching the Docker buildpath.
bash -n.immutable CuRobo commit.
git diff --checkpasses.validated on H20 for shared and non-shared paths at dimensions 7, 31, 33,
175, and 224.
The full multi-environment Docker image was not rebuilt as part of this change.