#2193: add alternatives and dependencies to auto-completion entries - #2390
Open
Hiepiscus wants to merge 10 commits into
Open
#2193: add alternatives and dependencies to auto-completion entries#2390Hiepiscus wants to merge 10 commits into
Hiepiscus wants to merge 10 commits into
Conversation
…o-completion' into 2193-support-for-conditional-auto-completion
Collaborator
Coverage Report for CI Build 33372059770Coverage decreased (-0.009%) to 73.619%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions10 previously-covered lines in 4 files lost coverage.
Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2193
This PR extends the auto-completion model with support for alternatives and dependencies between
CompletionEntryobjects.Implemented changes:
CompletionEntrywith alternative relationships.CompletionEntrywith dependency groups.AutoCompletionRegistry.addAlternative(String, String)connects two previously registered completion entries.addDependency(String, List<String>)registers an OR-dependency group for a previously registered entry.IllegalStateExceptionif a referenced candidate has not been registered withadd(String).exec:javaandexec:execare registered as alternatives.-Dexec.mainClass=depends onexec:java.-Dexec.args=depends on eitherexec:javaorexec:exec.CompleteTest:Testing instructions
build-local-dev.shide mvn exec:execand use the auto completion with<tab><tab>exec:javaide mvn -Dand use<tab><tab>-Dexec.mainClass=or-Dexec.argsis not in the outputide mvn exec:java -Dand use `-Dexec.mainClass=or-Dexec.argside mvn exec:exec -Dand use<tab><tab>-Dexec.argsChecklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.batand notfeature/921 fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalpom.xmlfiles or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc