#2293: rework spyder as ide tool commandlet

[JoelAdbu]

This PR fixes #2293

Implemented changes:

• added new interface for IDE specific features
• extracted workspace configuration logic into new class
• PipBasedIdeToolCommandlet and IdeToolCommandlet are implementing this new interface
• added new merger for .ini files
• adjusted Spyder conf variable to get configuration from workspace
• added new interface for plugin features
• extracted plugin logic from PluginBasedToolCommandlet to new class
• PluginBasedToolCommandlet and PipBasedToolCommandlet are implementing the new plugin features interface

---

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

Test for workspace configuration

1. Run

mvn clean test

2. Create a new project with the updated settings repository

ide create spyder https://github.com/JoelAdbu/ide-settings/tree/feature/2293-rework-spyder-as-ide-commandlet

3. Add the following spyder configuration to settings/spyder/workspace/update/.spyder-py3/config/spyder.ini with following content:

[appearance]
ui_theme = dark
font/family = JetBrains Mono
font/size = 25
app_font/family = JetBrains Mono
app_font/size = 25
monospace_app_font/family = JetBrains Mono
monospace_app_font/size = 25
selected = obsidian
 
[main]
font/family = JetBrains Mono
font/size = 25

4. Go to settings/spyder/plugins and set one of the plugins (e.g. SpyderLineProfiler) to active= true.

5. Start spyder

ide spyder

6. Verify Spyder opens the correct project.
7. Verify that the configured settings are applied (e.g. dark theme, Obsidian color scheme, JetBrains Mono font, font size 25)
8. Verify plugin line-profiler is downloaded and applied (in settings tab -> Line Profiler)

Verify plugin support and workspace configuration still work for IDEs (VS Code, IntelliJ, Eclipse)

 

1. Use the same project.

2. Modify a workspace setting, for example in:

vscode/workspace/update/.vscode/.userdata/User/settings.properties
 
Add the following setting:
 

"editor.fontSize": 30

 
4. Enable one or more plugins by setting active=true, for example in:
 
vscode/plugins/angular2.properties
 
5. Start VS Code:
 

ide vscode

6. Verify that the editor font size is visibly larger than the default value.

• Alternatively, open the VS Code settings and verify that editor.fontSize is set to 30.
   

7. Verify that the configured plugins have been installed successfully.

• Check that the plugin files are present under plugins/vscode/....
• Verify that the plugin appears in the VS Code Extensions view.
• Verify that the plugin is enabled and usable inside VS Code.

---

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

• When running mvn clean test locally all tests pass and build is successful
• PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat and not feature/921 fixed setup.bat). If no issue ID exists, title only.
• PR top-level comment summaries what has been done and contains link to addressed issue(s)
• PR and issue(s) have suitable labels
• Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
• You followed all coding conventions
• You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labelled
  with internal
• You have not changed any dependency in pom.xml files or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc
• You have formulated clear instructions on how to test your contribution under "Testing instructions"

[coveralls]

Coverage Report for CI Build 33411924319

Coverage decreased (-0.5%) to 73.138%

Details

• Coverage decreased (-0.5%) from the base build.
• Patch coverage: No coverable lines changed in this PR.
• 44 coverage regressions across 4 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

44 previously-covered lines in 4 files lost coverage.

File	Lines Losing Coverage	Coverage
com/devonfw/tools/ide/tool/pip/PipBasedIdeToolCommandlet.java	31	46.43%
com/devonfw/tools/ide/merge/DirectoryMerger.java	10	66.38%
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java	2	88.24%
com/devonfw/tools/ide/tool/plugin/PluginBasedCommandlet.java	1	95.0%

---

Coverage Stats

Relevant Lines:	18566
Covered Lines:	14199
Line Coverage:	76.48%
Relevant Branches:	8208
Covered Branches:	5383
Branch Coverage:	65.58%
Branches in Coverage %:	Yes
Coverage Strength:	3.26 hits per line

---

💛 - Coveralls