fix(core): align withBaseAvailability formula with makeScore#131
Open
Emran-goat wants to merge 2 commits into
Open
fix(core): align withBaseAvailability formula with makeScore#131Emran-goat wants to merge 2 commits into
Emran-goat wants to merge 2 commits into
Conversation
…mment classifier.ts:164 had a French error message in an otherwise English codebase. Changed to English for consistency. pt-BR.ts:1824 had a TODO:translate comment that was already done. Removed it.
parser.ts:withBaseAvailability recomputes the confidence score when zdiff3 is detected but was missing the algorithmStability and postMergeRisk terms from the documented v2.4 formula.
Collaborator
|
@devlint Looking good to me. I less know about that part: (So i let you the final review) For another PR@devlint @Emran-goat i guess if you want to contribute to another PR and try to do the translation with an LLM/Claude or other, it could be a nice and easy win. :) |
Contributor
Author
|
and just opened #134 for the one leftover French console.error i found in the resolver. everything else was already clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parser.ts:withbaseavailability was computing the confidence score without two terms from the v2.4 formula (algorithmstability and postmergerisk). both are always 0 right now so nothing breaks numerically. but if someone ever sets these dimensions the formula would silently give a wrong score. this keeps both implementations in sync before it becomes a problem.