Update theme packages#565
Open
eebbi wants to merge 11 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the theme build/tooling stack (Node + webpack ecosystem) to support newer dependency versions as part of ongoing maintenance for Tampere multisite support.
Changes:
- Migrate webpack config toward Webpack 5 conventions (asset modules,
resolve.fallback, ESLint viaeslint-webpack-plugin). - Bump Node version and update a wide set of frontend build/lint dependencies.
- Update CI workflow Node setup, plus a small JS runtime bugfix in
Toggle.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
webpack.config.js |
Updates webpack config for Webpack 5 (asset modules, ESLint plugin, resolve.fallback). |
package.json |
Upgrades build/lint toolchain dependencies (webpack 5, loaders, ESLint, etc.). |
CHANGELOG.MD |
Notes the Node/webpack/dependency version updates in Unreleased. |
assets/scripts/toggle.js |
Fixes typeof comparison when reading optional duration data attribute. |
.nvmrc |
Pins Node to v18.20.4. |
.github/workflows/phpcs-check.yml |
Updates actions/cache to v4. |
.github/workflows/npm-check.yml |
Updates setup-node to v4 and moves CI Node to 18.x. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+37
to
+39
| "eslint-webpack-plugin": "^4.2.0", | ||
| "file-loader": "^6.2.0", | ||
| "image-webpack-loader": "^7.0.1", | ||
| "image-webpack-loader": "^8.1.0", |
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '14' | ||
| node-version: '18' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project: Tampereen kaupunki, konsernihallinto / Tietohallintoyksikkö:
Project task: Tampere multisite support
Task: https://hiondigital.atlassian.net/browse/TMS-1025
Task title: Projektin ylläpito