Skip to content

Update theme packages#565

Open
eebbi wants to merge 11 commits into
masterfrom
update-packages-04-2026
Open

Update theme packages#565
eebbi wants to merge 11 commits into
masterfrom
update-packages-04-2026

Conversation

@eebbi

@eebbi eebbi commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Project: Tampereen kaupunki, konsernihallinto / Tietohallintoyksikkö:
Project task: Tampere multisite support

Task: https://hiondigital.atlassian.net/browse/TMS-1025
Task title: Projektin ylläpito

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the theme build/tooling stack (Node + webpack ecosystem) to support newer dependency versions as part of ongoing maintenance for Tampere multisite support.

Changes:

  • Migrate webpack config toward Webpack 5 conventions (asset modules, resolve.fallback, ESLint via eslint-webpack-plugin).
  • Bump Node version and update a wide set of frontend build/lint dependencies.
  • Update CI workflow Node setup, plus a small JS runtime bugfix in Toggle.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
webpack.config.js Updates webpack config for Webpack 5 (asset modules, ESLint plugin, resolve.fallback).
package.json Upgrades build/lint toolchain dependencies (webpack 5, loaders, ESLint, etc.).
CHANGELOG.MD Notes the Node/webpack/dependency version updates in Unreleased.
assets/scripts/toggle.js Fixes typeof comparison when reading optional duration data attribute.
.nvmrc Pins Node to v18.20.4.
.github/workflows/phpcs-check.yml Updates actions/cache to v4.
.github/workflows/npm-check.yml Updates setup-node to v4 and moves CI Node to 18.x.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/npm-check.yml Outdated
Comment thread package.json
Comment on lines +37 to +39
"eslint-webpack-plugin": "^4.2.0",
"file-loader": "^6.2.0",
"image-webpack-loader": "^7.0.1",
"image-webpack-loader": "^8.1.0",
- uses: actions/setup-node@v4
with:
node-version: '14'
node-version: '18'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants