Repository navigation
fix(pptx): honor slide background for useBgFill - #2048
Merged
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File submission policy
Summary
PPTX shapes with
p:sp/@useBgFill="1"now use the resolved slide background instead of the stylea:fillRefcolor. The parser resolves the background before it finalizes slide, layout, and master shapes, and the regression covers both a focused style-fill case and the public issue fixture.Related issue
Related: #1879
Testing
cargo fmt --all -- --check— passed.git diff --check origin/main...HEAD— passed.cargo test --locked --workspace --profile ci— passed locally after the shape-finalization refactor.cargo clippy --locked --workspace --all-targets -- -D warnings— passed locally.SlideParseContextto avoid duplicating its inputs.71e10311; hosted runtime CI passed on the matching integration tree. The fresh native PowerPoint layout, text, render and strict-cluster audit is complete.Visual impact
Visual audit
tests/fixtures/pptx/1-slide.pptxfixassets/bugfixes/issue-1879/layout-audit.jsonassets/bugfixes/issue-1879/render-clusters-page-1.jsonassets/bugfixes/issue-1879/gt.jpgassets/bugfixes/issue-1879/before.jpgassets/bugfixes/issue-1879/after.jpgVisual comparison
Required inspection
Deviation audit
Checklist
Signed-off-byline