Repository navigation
fix: resolve DOCX table style cell margins - #2044
Merged
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File submission policy
Summary
Resolved DOCX table-style cell margins are now complete. A style named “Normal Table” uses Word’s latent 0/108/0/108 twip margins when its own margin declaration is absent or partial. Other resolved styles preserve declared sides and inherit unspecified sides from the default table style, or use zero when that default supplies no value. Direct table and per-cell margin precedence remains unchanged.
Four generated DOCX probes cover absent and one-sided style margins under both “Normal Table” and “Grid Probe” names. The style IDs deliberately differ from the names so the regression verifies Word’s name-based built-in resolution.
Related issue
Related: #1884
Related: #1874
Testing
cargo fmt --all -- --checkandgit diff --checkpassed.cargo test --locked --workspace --profile cipassed after integrating main71e10311; a fresh--docrun also passed after the separate CLI build.cargo clippy --locked --workspace --all-targets -- -D warningspassed.Visual impact
Visual audit
tests/fixtures/docx/issue-1884-normal-absent.docx,tests/fixtures/docx/issue-1884-normal-partial.docx,tests/fixtures/docx/issue-1884-custom-absent.docx,tests/fixtures/docx/issue-1884-custom-partial.docxfixassets/bugfixes/issue-1884/layout-audit.jsonassets/bugfixes/issue-1884/render-clusters-page-1.json,assets/bugfixes/issue-1884/render-clusters-page-2.json,assets/bugfixes/issue-1884/render-clusters-page-3.json,assets/bugfixes/issue-1884/render-clusters-page-4.jsonassets/bugfixes/issue-1884/gt.jpgassets/bugfixes/issue-1884/before.jpgassets/bugfixes/issue-1884/after.jpgVisual comparison
Required inspection
Deviation audit
Checklist
Signed-off-byline