Repository navigation
fix: honor PPTX table-cell first-line indents - #2043
Merged
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File submission policy
Summary
PPTX parsing preserves the paragraph left margin (marL) and signed first-line offset (indent), but table-cell rendering previously applied only the paragraph margins and omitted the signed first-line offset. The renderer now applies the signed offset as a first-line indent in either direction, so continuation lines stay at the paragraph left margin.
The geometry regression uses a fixed Libertinus Serif 10 pt font and a 110 pt cell to force wrapping. It checks negative, zero, and positive offsets, including that only the first line moves. The parser regression checks the reported 60.75 pt left margin and -18 pt offset.
Related issue
Related: #2041
Testing
cargo fmt --all -- --checkandgit diff --checkpassed.cargo test --locked --workspace --profile cipassed after integrating main71e10311(3,579 library tests, integration suites, and doctests).cargo clippy --locked --workspace --all-targets -- -D warningspassed.Visual impact
Visual audit
tests/fixtures/pptx/oxp_PB001-Input1.pptxfixassets/bugfixes/issue-2041/layout-audit.jsonassets/bugfixes/issue-2041/render-clusters-page-1.json,assets/bugfixes/issue-2041/render-clusters-page-2.jsonassets/bugfixes/issue-2041/gt.jpgassets/bugfixes/issue-2041/before.jpgassets/bugfixes/issue-2041/after.jpgVisual comparison
Required inspection
Deviation audit
Checklist
Signed-off-byline