Fix broken golangci-lint installation in go feature#1632
Fix broken golangci-lint installation in go feature#1632max06 wants to merge 2 commits intodevcontainers:mainfrom
Conversation
There was a problem hiding this comment.
We (golangci-lint maintainers) recommend using https://golangci-lint.run/install.sh instead of an URL based of a branch.
https://golangci-lint.run/docs/welcome/install/local/#binaries
This is for several reasons:
- GitHub applies new rate limits
- Referencing a branch can be brittle
Use official url for the install-script Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
|
Confirming this hits us on |
|
I can confirm that fixing linter to older version fixes the problem until this PR is merged. {
"features": {
"ghcr.io/devcontainers/features/go:1": {
"golangciLintVersion": "2.11.4"
}
}
} |
|
@bamurtaugh Good morning and sorry for the ping - could you please try to speed this up a bit? It shouldn't take days to merge a simple fix. |
Currently using the go-feature in devcontainers without specifying an older version to install breaks building devcontainers.
After investigating, 2 reasons were identified for breaking:
This should be merged quickly.
Potential workaround: Using
v2.11.4as version for golangci-lint should work since sbom-files were added in v2.12 for the first time.