Updates "outdated" command to display stale image versions#768
Open
samruddhikhandale wants to merge 21 commits intomainfrom
Open
Updates "outdated" command to display stale image versions#768samruddhikhandale wants to merge 21 commits intomainfrom
samruddhikhandale wants to merge 21 commits intomainfrom
Conversation
joshspicer
reviewed
Mar 6, 2024
chrmarti
requested changes
Mar 7, 2024
Contributor
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
This will be a great addition! Left a few comments.
joshspicer
reviewed
Mar 7, 2024
chrmarti
requested changes
Mar 8, 2024
cklim2024
approved these changes
Mar 8, 2024
|
__dolve |
chrmarti
approved these changes
Mar 11, 2024
Contributor
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
Looks good! Left a comment for a small correction, approving now.
| const wantedVersion = latestVersion.split('.').slice(0, version.split('.').length).join('.'); | ||
| const wantedTag = tagSuffix ? `${wantedVersion}-${tagSuffix}` : wantedVersion; | ||
| const latestVersion = latestSemVersion.split('.').slice(0, version.split('.').length).join('.'); | ||
| const wantedTag = tagSuffix ? `${latestVersion}-${tagSuffix}` : latestVersion; |
Contributor
There was a problem hiding this comment.
nit: Should this be latestTag?
cklim2024
approved these changes
Mar 12, 2024
cklim2024
reviewed
Mar 12, 2024
cklim2024
approved these changes
Mar 12, 2024
AZOLOOK
approved these changes
Mar 19, 2024
AZOLOOK
approved these changes
Mar 19, 2024
AZOLOOK
approved these changes
Mar 19, 2024
AZOLOOK
approved these changes
Mar 19, 2024
AZOLOOK
approved these changes
Mar 19, 2024
AZOLOOK
approved these changes
Mar 19, 2024
cklim2024
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, we integrated Dependabot and Dev Containers where we get PRs to update
versionsfor stale Features.Similarly, for the devcontainer/images, we have been worried of bumping a major version of an image because folks could be left behind on stale images (which doesn't receive security patches). Currently, we don't have a good way of alerting the community when a new image version becomes available (besides putting up notices and announcing in the community channels). Out of public repos, 2600 dev containers are using the stale
mcr.microsoft.com/devcontainers/pythonimage (older major version which ww don’t support).Hence, this PR updates the
outdatedcommand to include the stale image versions. It looks for the.devcontainer.jsonfile, and looks for corresponding images in.devcontainer.json, Dockerfiles or Compose files (based on the dev container structure)The
outdatedcommand currently supports only the images hosted from https://github.com/devcontainers/images. Reasoning: I looked at some popular images (eg. python, node, go, php etc), however, they don’t use semantic versioning. Hence, doesn’t make sense to implement for them.Example - Image pinned to semver
Example - Image pinned to major and major.minor