Conversation
|
🐕 Review complete — View session on Shuni Portal 🐾 |
![wiz-d45ab51820[bot]](https://avatars.githubusercontent.com/b/12521?s=60&v=4){kind=small}
omercnet
force-pushed
the
break/droppy38
branch
3 times, most recently
from
744c536 to
bce931a
Compare
![shuni-bot-dev[bot]](https://avatars.githubusercontent.com/u/97479186?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐕 Shuni's Review
Drops Python 3.8 support, switches license checker from liccheck to pylic, and aligns pre-commit hook versions with poetry dev deps.
Sniffed out 3 issues:
- 1 🟠 HIGH: pylic
safe_licensesis missing license entries that liccheck previously authorized (certifi/MPL-2.0,email-validator/CC0-1.0) - 1 🟡 MEDIUM:
pyupgradestill pinned to--py38-plusdespite dropping 3.8 - 1 🟢 LOW: YAML indentation inconsistency for the new
pylicrepo entry
See inline comments. Needs a bath!
omercnet
force-pushed
the
break/droppy38
branch
from
bce931a to
5eb3bda
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR drops Python 3.8 support and updates development/compliance tooling accordingly, including migrating license checking from liccheck to pylic and refreshing pinned tooling/dependency artifacts.
Changes:
- Bump minimum supported Python version to 3.9 and remove Python 3.8 classifier/conditional dependency specs.
- Replace
liccheck(andliccheck.ini) withpylic, configuring policy inpyproject.tomland wiring it into pre-commit. - Regenerate/export dependency lock and requirements artifacts to reflect the updated tooling and Python support.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
requirements.txt |
Updates exported/pinned dependency set (and markers) for Python >=3.9. |
pyproject.toml |
Raises minimum Python to 3.9, simplifies dev/format dependency constraints, and adds [tool.pylic] configuration. |
poetry.lock |
Regenerated lockfile under the updated Python/tooling setup (Poetry v2 format/metadata changes). |
liccheck.ini |
Removes legacy liccheck license policy configuration. |
.pre-commit-config.yaml |
Pins formatter/linter hook versions and adds the pylic hook while removing the legacy liccheck hook. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
omercnet
force-pushed
the
break/droppy38
branch
2 times, most recently
from
271f42c to
de800d3
Compare
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
omercnet
force-pushed
the
break/droppy38
branch
from
2ca0bef to
9dfcb97
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Flask 3.1 removed the long-deprecated _request_ctx_stack, causing the mypy 'type' tox env (only run on 3.12/3.13) to fail with: samples/magiclink_web_sample_app.py:1: error: Module "flask" has no attribute "_request_ctx_stack" [attr-defined] The library code already uses flask.g; align the sample with it. Also clean up tox.ini: drop py38 from env_list and report.depends, and remove the dead [testenv:py37] block, matching this branch's intent of dropping Python 3.8.
…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
LioriE
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project to drop support for Python 3.8, standardize Python version requirements, and replace the
licchecklicense checker withpylic. It also updates development dependencies and configuration files for improved consistency and maintainability.Python version support and requirements:
README.md,.github/workflows/ci.yml,pyproject.toml,tox.ini) [1] [2] [3] [4] [5] [6]License checking and compliance:
licchecktool and its configuration (liccheck.ini) withpylic, updating pre-commit hooks and specifying allowed licenses inpyproject.toml. (pyproject.toml,.pre-commit-config.yaml,liccheck.ini) [1] [2] [3] [4]Development and formatting tools:
pre-commit,black, andflake8, and removed Python-version-specific dependency logic. (pyproject.toml,.pre-commit-config.yaml) [1] [2] [3]Let me know if you want more details on any of these changes!