Make TypeEq and its inner types interfaces#31
Open
gneuvill wants to merge 3 commits into
Open
Conversation
clinuxrulz
approved these changes
May 26, 2017
clinuxrulz
left a comment
clinuxrulz
left a comment
There was a problem hiding this comment.
Looks good to me. Bit of a noise reduction for some uses.
jbgi
reviewed
Jun 2, 2017
| * @param <D> the last type variable after substitution. | ||
| * @return a factory to lift the TypeEq instances into any type constructor. | ||
| */ | ||
| public final <C, D> Lift2TypeEq<A, C, B, D> lift2(TypeEq<C, D> cd) { |
Member
There was a problem hiding this comment.
I am a bit concerned about the removal of those type inference helpers (Lift2TypeEq, Lift3TypeEq). I think they can be useful. @gneuvill could you add them back in some way?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @jbgi and I discussed on gitter. I wonder if we could get rid of a number of casts by instantiating TypeEq through method references....