Skip to content

Address the warning given by haxe 5.0.#41

Open
qlambert-pro wants to merge 1 commit into
deepnight:masterfrom
qlambert-pro:macro-display
Open

Address the warning given by haxe 5.0.#41
qlambert-pro wants to merge 1 commit into
deepnight:masterfrom
qlambert-pro:macro-display

Conversation

@qlambert-pro

Copy link
Copy Markdown

I have been experimenting with the upstream version of haxe and ran into warnings this PR applies the suggestion given in the message.

 [WARNING] (macro) /usr/share/haxe/lib/ldtk-haxe-api/git/src/ldtk/macro/TypeBuilder.hx:3: characters 17-24


   3 | #if( !macro && !display )
     |                 ^^^^^^^
     | (WIfDisplay) Using `display` here doesn't work because #if conditions are evaluated at parse time. In macros, use `haxe.macro.Context.defined("display")` instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant