Make s/build-prod-images.sh runnable unattended (CI) - #749
Open
IvanTheGeek wants to merge 1 commit into
Open
Conversation
Three small fixes so the prod build can run without a human at the keyboard: - Skip the 'Continue [y/n]?' confirmation when TY_NONINTERACTIVE is set or stdin isn't a tty — in CI the read would just fail or hang. - Skip the wait-for-Selenium-on-:4444 loop when --skip-e2e-tests is passed: the build blocked forever waiting for a browser that the run would never use. - Actually read target/build-exit-code — the assignment was commented out, so the 'Build result: ..., exit code:' line always printed an empty exit code; also tolerate a missing status file instead of crashing on cat. No behavior change for interactive use: with a tty and no TY_NONINTERACTIVE, the y/n prompt and (when e2e will run) the Selenium wait behave as before. Tested: 'make prod-images-skip-build-and-e2e-test' now runs end-to-end unattended to 'Build result: BUILD_OK, exit code: 0' (inside a container with no tty). Co-authored-by: Claude Fable 5 <noreply@anthropic.com> I, Ivan Rainbolt <talkyard@github-commits.ivanthegeek.com>, agree to the Contributor License Agreement, docs/CLA-v2.txt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small fixes so
make prod-imagesvariants can run with no human at the keyboard:Continue [y/n]?prompt is skipped whenTY_NONINTERACTIVEis set or stdin isn't a tty — in CI thereadjust fails or hangs.until curl :4444) is skipped when--skip-e2e-testsis passed — it blocked forever waiting for a browser that run would never use.build_exit_codewas only assigned in a commented-out line, soBuild result: ..., exit code:always printed empty. Now both files are read (and a missing status file doesn't crash the script).Interactive behavior is unchanged (tty + no env var ⇒ same prompt, same Selenium wait when e2e runs).
Tested:
make prod-images-skip-build-and-e2e-testruns end-to-end unattended toBuild result: BUILD_OK, exit code: 0inside a tty-less container.Part of the same Docker-only-build/CI work as #747 and #748.
🤖 Generated with Claude Code