Skip to content

Follow-up (#373): tighten vacuous positive assertion in ast_tests.rs #390

Closed

Description

@dean0x

Context

In run_ast_standalone_resolves_nested_dir_corpus_correctly (crates/rskim/src/cmd/search/ast_tests.rs), the positive assertion text.contains("foo/bar.rs") || text.contains("foo") && text.contains("bar.rs") parses (Rust precedence) as contains("foo/bar.rs") || (contains("foo") && contains("bar.rs")). With the corpus foo.rs / foo/bar.rs / foobar.rs the second disjunct is ALWAYS true, so the positive check can never fail on a regression. (The two negative assertions still have teeth.)

Definition of done

Tighten the positive assertion to assert!(text.contains("foo/bar.rs")).

Origin: #373. Refs #174.

Activity

  1. dean0x commented on Jul 2, 2026

    @dean0x
    OwnerAuthor

    Resolved in ac03b8d (PR #386 → wave/wave4-search): tightened the vacuous positive assertion in ast_tests.rs (PF-007). CI-green.

  2. dean0x commented on Jul 2, 2026

    @dean0x
    OwnerAuthor

    Resolved in PR #386 (merged to wave/wave4-search @ ea99703): targeted test/perf hardening + #380 Phase 2 positional search. Not yet on main — ships with PR #368 (wave→main).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech-debtTechnical debt backlog item

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions