You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Follow-up (#373): tighten vacuous positive assertion in ast_tests.rs #390
In run_ast_standalone_resolves_nested_dir_corpus_correctly (crates/rskim/src/cmd/search/ast_tests.rs), the positive assertion text.contains("foo/bar.rs") || text.contains("foo") && text.contains("bar.rs") parses (Rust precedence) as contains("foo/bar.rs") || (contains("foo") && contains("bar.rs")). With the corpus foo.rs / foo/bar.rs / foobar.rs the second disjunct is ALWAYS true, so the positive check can never fail on a regression. (The two negative assertions still have teeth.)
Definition of done
Tighten the positive assertion to assert!(text.contains("foo/bar.rs")).
Resolved in PR #386 (merged to wave/wave4-search @ ea99703): targeted test/perf hardening + #380 Phase 2 positional search. Not yet on main — ships with PR #368 (wave→main).
Activity
test(search): tighten vacuous AST corpus assertion (#390, #386)
dean0x commentedon Jul 2, 2026
Resolved in
ac03b8d(PR #386 → wave/wave4-search): tightened the vacuous positive assertion in ast_tests.rs (PF-007). CI-green.dean0x commentedon Jul 2, 2026
Resolved in PR #386 (merged to
wave/wave4-search@ ea99703): targeted test/perf hardening + #380 Phase 2 positional search. Not yet onmain— ships with PR #368 (wave→main).