Repository navigation
Conversation
DdevRunner registers the share process with the new project-level ShareManager and clears it when the process ends. stopShare destroys it, and the Share action is disabled while a share is running. Runner.run gains an overload that hands the started process to a consumer.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
The plugin starts
ddev sharein a run console and then loses track of it. Nothing can stop the share or react to its output, so the share tickets have nothing to build on.How this PR Solves the Problem:
ShareManagerservice holds the running share process.Runner.rungets an overload that hands the startedProcessHandlerto a consumer.DdevRunnerImpl.shareuses it to register the process and clears it when the process ends.DdevRunner.stopSharedestroys the running share process.This is groundwork only. The follow-up PRs for #53 (show the public URL) and #8 (ngrok errors, Stop Sharing action) build on it.
Manual Testing Instructions:
Tests cover
ShareManager, the share and stopShare runner calls, the process consumer inRunnerImpland the disabled Share action../gradlew checkpasses for both platform variants (251 and 261).Related Issue Link(s):
Groundwork for #8 and #53.