Repository navigation
build: base prerelease notes on the channel's previous tag - #545
Merged
Merged
Conversation
Generated notes compared against the newest release of any kind, so an alpha listed its changes relative to a beta. They now compare against the previous tag of the same channel and target version, or the latest stable release for the first one.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
GitHub's generated release notes compare against the newest release of any kind.
1.3.0-alpha5was created right after1.2.11-beta1, so its notes compared1.2.11-beta1...1.3.0-alpha5, a diff between two unrelated lines.How this PR Solves the Problem:
The version job also outputs
previous: the highest existing tag of the same channel and target version (1.3.0-alpha5for the next alpha), or the latest stable release when it is the first one. The release step passes it asprevious_tag.Manual Testing Instructions:
actionlint passes. Dry-run of the version step against this repository: alpha gives
1.3.0-alpha6with base1.3.0-alpha5, beta gives1.2.11-beta2with base1.2.11-beta1.The existing
1.3.0-alpha5release notes were regenerated against1.2.10by hand.Related Issue Link(s):
Follow-up to #544, refs #538