Repository navigation
test: expect HTTP 303 from the login redirect in Adminer 6.3.0 - #59
Merged
Merged
Conversation
## Short Summary (TL;DR) Adminer 6.3.0 redirects with HTTP 303 instead of 302, so the health check now expects 303. ## The Issue The scheduled test run [41799823883](https://github.com/ddev/ddev-adminer/actions/runs/41799823883/job/126472573296) failed in all 4 tests with `output does not contain substring: HTTP/2 302`. The run used the same commit as the passing run on 2026-11-03. ## How This PR Solves The Issue The `adminer:6-standalone` image updated to Adminer 6.3.0 on 2026-11-03. Adminer commit [a92b834](vrana/adminer@a92b834208) makes `Adminer\redirect()` send 303 by default. The passwordless login plugin uses this function, so its redirect now returns 303. Browsers follow 302 and 303 the same way, so users see no change. The test now expects `HTTP/2 303`. ## Manual Testing Instructions ```bash ddev add-on get ddev/ddev-adminer --pr 59 ddev restart curl -sI https://<project>.ddev.site:9101 | head -1 # Expect HTTP/2 303 ddev adminer # Expect Adminer to open logged in to the db database ``` ## Automated Testing Overview Claude Code ran `install from directory`, `install from directory with nonstandard port and .env.adminer` and `install from directory with sqlite and .env.adminer` with `adminer:6-standalone` (6.3.0) on Linux, and they passed. Nobody ran `install from release` locally, so the scheduled CI run will confirm it. 🤖 Developed with assistance from [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Summary (TL;DR)
Adminer 6.3.0 redirects with HTTP 303 instead of 302, so the health check now expects 303.
The Issue
The scheduled test run 41799823883 failed in all 4 tests with
output does not contain substring: HTTP/2 302. The run used the same commit as the passing run on 2026-11-03.How This PR Solves The Issue
The
adminer:6-standaloneimage updated to Adminer 6.3.0 on 2026-11-03. Adminer commit a92b834 makesAdminer\redirect()send 303 by default. The passwordless login plugin uses this function, so its redirect now returns 303. Browsers follow 302 and 303 the same way, so users see no change. The test now expectsHTTP/2 303.Manual Testing Instructions
Automated Testing Overview
Claude Code ran
install from directory,install from directory with nonstandard port and .env.adminerandinstall from directory with sqlite and .env.adminerwithadminer:6-standalone(6.3.0) on Linux, and they passed. Nobody raninstall from releaselocally, so the scheduled CI run will confirm it.🤖 Developed with assistance from Claude Code