Repository navigation
fix: load the review skill only in DDEV repositories - #4
Merged
Merged
Conversation
## Short Summary (TL;DR) `/ddev:review` loaded in repositories outside DDEV. Its description and its first step now limit it to DDEV repositories, and AGENTS.md describes how to check when a skill loads. ## The Issue In a dotfiles repository, "let's review last commit" loaded `/ddev:review`. The trigger phrases matched, and the description mentioned DDEV repositories only in passing. ## How This PR Solves The Issue - The description names the repositories the skill is for: a remote under `github.com/ddev`, a fork of one, or a DDEV add-on. It also says the skill is not for other repositories. - The skill's first step checks `git remote -v`, or a fork's parent with `gh`. In another repository it tells the user it doesn't apply and reviews without it. This catches the cases where the description still loads the skill. The check is a plain instruction, so it applies in Codex too. - Two other ways don't fit. Claude Code's `paths` frontmatter matches the files Claude reads, not the repository. Enabling the plugin per repository needs one install in every clone. ## Manual Testing Instructions ```bash gh pr checkout 4 ``` Follow "When a skill should load" in AGENTS.md. Expect `ddev:review` in the repository with a `github.com/ddev/` remote, and no output in the other one. ## Automated Testing Overview No automated test covers skill loading. Claude Code ran the AGENTS.md command with Opus 5.5 in two throwaway repositories. Before this change, the installed plugin loaded `ddev:review` in the one without a DDEV remote. After it, `ddev:review` loaded in 3 of 3 runs in the DDEV repository and in 0 of 3 runs in the other one. In a repository whose only remote is a fork of ddev/ddev, it loaded in 2 of 2 runs. Claude went by the remote's name there, without the `gh` check. Not tested: Codex. 🤖 Developed with assistance from [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Summary (TL;DR)
/ddev:reviewloaded in repositories outside DDEV. Its description and its first step now limit it to DDEV repositories, and AGENTS.md describes how to check when a skill loads.The Issue
In a dotfiles repository, "let's review last commit" loaded
/ddev:review. The trigger phrases matched, and the description mentioned DDEV repositories only in passing.How This PR Solves The Issue
github.com/ddev, a fork of one, or a DDEV add-on. It also says the skill is not for other repositories.git remote -v, or a fork's parent withgh. In another repository it tells the user it doesn't apply and reviews without it. This catches the cases where the description still loads the skill. The check is a plain instruction, so it applies in Codex too.pathsfrontmatter matches the files Claude reads, not the repository. Enabling the plugin per repository needs one install in every clone.Manual Testing Instructions
Follow "When a skill should load" in AGENTS.md. Expect
ddev:reviewin the repository with agithub.com/ddev/remote, and no output in the other one.Automated Testing Overview
No automated test covers skill loading. Claude Code ran the AGENTS.md command with Opus 5.5 in two throwaway repositories. Before this change, the installed plugin loaded
ddev:reviewin the one without a DDEV remote. After it,ddev:reviewloaded in 3 of 3 runs in the DDEV repository and in 0 of 3 runs in the other one. In a repository whose only remote is a fork of ddev/ddev, it loaded in 2 of 2 runs. Claude went by the remote's name there, without theghcheck.Not tested: Codex.
🤖 Developed with assistance from Claude Code