Skip to content

Shouldn't __contain__ use keys?  #35

Description

@harisund

Lines 36 and 37

def __contains__(self, future):
    return future in self._futures.values()

Shouldn't this be either self._futures.keys() or atleast self._futures?

In lines 45 through 46 you have

if future_key not in self._futures:
    return None

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions