Repository navigation
feat(core): C10 zoom-out LOD — hold nodes/links at fit-all, resolve clicks via the spatial index - #99
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016V6PyVUq4G2LMR9EfXZEMk
…ons (C10 LOD steps 3-6) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016V6PyVUq4G2LMR9EfXZEMk
…(C10 LOD steps 7-8) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016V6PyVUq4G2LMR9EfXZEMk
…on record (C10 LOD step 9) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016V6PyVUq4G2LMR9EfXZEMk
…ord-only budgets (C10 LOD step 10) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016V6PyVUq4G2LMR9EfXZEMk
…s (C10 LOD steps 11-12) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016V6PyVUq4G2LMR9EfXZEMk
…step 13) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016V6PyVUq4G2LMR9EfXZEMk
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016V6PyVUq4G2LMR9EfXZEMk
…ep 10) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016V6PyVUq4G2LMR9EfXZEMk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the approved C10 zoom-out level of detail (design Amendment A2,
docs/design/2026-10-07-c10-lod-zoom-out/), which supersedes the label-only LOD planned in the original C10 design.Culling— at scale ≤ 0.16 (LOD_SCALE_ON) nodes and links are held (paint hidden via the existingdata-pfd-transientattribute;<g>, accessible name and focusability stay); labels and zones stay painted. Off above 0.20 (LOD_SCALE_OFF). Entering is budgeted (HIDE_BUDGET/frame); leaving is synchronous, including while culling is inert.data-pfd-lod=off/entering/on. No public option:culling: falsedisables it; an@internallod:falseharness switch gives the perf gate a same-build baseline.<class>.click|dblclick. Events are marked in aWeakSet(features/resolvedEvents.ts);Zoom's background handler andMouseEvents' per-element listeners skip marked events, so nothing is delivered twice and d3-zoom's double-click zoom still runs. Ignored while the link tool is active; keyboard/synthesised clicks stay native.wronglyHeldoracle + real-mouse resolver cases for both arms, G4/G5/G6 re-run under LOD, perf arms.coreminor;viewer/interactive-viewer/editorpatch).Measurements (pinned container, n = 6;
lod-measurements.md)Separation safeguard holds in every run (6.9–8.9× better). New budgets in
perf-budget.json:fitAllPan50.1 ms (+ separation assertion),lodCrossing1052 ms worst frame.Known limitations (stated, not hidden)
detail > 0pointer discriminator is verified in Chromium only.Test plan
pnpm lint,pnpm format:check,pnpm typecheck,pnpm test(incl. editor property test)culling.spec.ts(G1–G7 + LOD + resolver, interactive and editor arms) locally and in the E2E laneperf.yml(pinned) green with the new budget assertions🤖 Generated with Claude Code
https://claude.ai/code/session_016V6PyVUq4G2LMR9EfXZEMk