[E2E] refactor and support youtube shorts in CI#370
Open
sarod wants to merge 4 commits into
Open
Conversation
|
📦 Web extension build artifacts: https://github.com/dataforgoodfr/14_BalanceTesHaters/actions/runs/28081275054/artifacts/7842373486 |
- share generic assertions - detect bot WIP
sarod
force-pushed
the
sarod/e2e-improvements
branch
from
3bd8b31 to
dd738d0
Compare
sarod
force-pushed
the
sarod/e2e-improvements
branch
2 times, most recently
from
737e048 to
a49a12e
Compare
sarod
changed the title
sarod
force-pushed
the
sarod/e2e-improvements
branch
2 times, most recently
from
7fc40b0 to
888342a
Compare
Youtube removes og: meta when it suspects bots. This commits adds a flag to allow running youtube scrapping when this data is missing returning placeholder value isntead of real value. This mode is only enabled in CI E2E runs * fix wait for scraping started detection when early failure
sarod
force-pushed
the
sarod/e2e-improvements
branch
from
f845fe1 to
214e095
Compare
AntoineQuesnel
approved these changes
Jun 26, 2026
| scrapingTabId, | ||
| ); | ||
| return status !== undefined && status.type === "running"; | ||
| return status !== undefined && status.type !== "not-started"; |
Collaborator
There was a problem hiding this comment.
Passer par une enum ou équivalent ?
| expect(allComments.length).toBeLessThanOrEqual(expectedCommentCount); | ||
| expect(allComments.length).toBeGreaterThanOrEqual( | ||
| Math.floor(commentCount * 0.7), | ||
| Math.floor(expectedCommentCount * 0.7), |
Collaborator
There was a problem hiding this comment.
Le 0.7 c'est en considérant qu'avec les éventuelles suppression de commentaire, il restera au moins 70% des commentaires initiaux ?
Si oui, ptete en faire une constante ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor e2e scrapping tests to:
Add support for e2e tests for youtube shorts scrapping by introducing a degraded scrapping mode that use placeholder values when data is missing due to youtube suspecting bot. This is only relevant when non authenticated scrapping on untrusted up (CI).