Skip to content

[DCP Ingestion] Modify the CDC Image Dockerfile and script to support the new DCP bridge mode#6254

Open
gmechali wants to merge 1 commit intodatacommonsorg:masterfrom
gmechali:dcpimg
Open

[DCP Ingestion] Modify the CDC Image Dockerfile and script to support the new DCP bridge mode#6254
gmechali wants to merge 1 commit intodatacommonsorg:masterfrom
gmechali:dcpimg

Conversation

@gmechali
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the CDC ingestion infrastructure to support a new 'dcpbridge' mode. The changes include necessary environment configurations in the Docker container and updates to the execution script to accommodate the new mode and allow for more flexible command-line argument passing.

Highlights

  • Infrastructure Updates: Updated the Dockerfile to include curl and the Google Cloud SDK, enabling automated workflow triggering.
  • Execution Configuration: Modified the Docker entrypoint to explicitly use bash for script execution and updated the run script to support the new 'dcpbridge' mode.
  • Script Flexibility: Updated the run script to pass additional arguments to the underlying Python process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the cdc_data Dockerfile to install the Google Cloud SDK and changes the entrypoint to bash. It also modifies run.sh to support the dcpbridge run mode and allows passing extra arguments to the stats processing script. A recommendation was made to use non-interactive flags and clean up the package cache in the Dockerfile to improve build reliability and reduce image size.

Comment thread build/cdc_data/Dockerfile
Comment on lines +34 to +35
RUN apt-get update && apt-get install -y curl \
&& curl -sSL https://sdk.cloud.google.com | bash
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The installation of the Google Cloud SDK should be non-interactive to prevent the build from hanging or failing in automated environments (like CI/CD). Additionally, it is best practice to clean up the apt cache and use --no-install-recommends to keep the Docker image size minimal.

RUN apt-get update && apt-get install -y --no-install-recommends curl \
    && curl -sSL https://sdk.cloud.google.com | bash -s -- --disable-prompts \
    && rm -rf /var/lib/apt/lists/*

@gmechali gmechali requested a review from dwnoble April 30, 2026 18:16
Comment thread build/cdc_data/run.sh
--output_dir=$DC_OUTPUT_DIR \
--mode=$DATA_RUN_MODE
--mode=$DATA_RUN_MODE \
"$@"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we plan on starting the ingestion workflow? Would it make sense to run gcloud command after this line (the stats.main execution) to keep them decoupled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants