[DCP Ingestion] Modify the CDC Image Dockerfile and script to support the new DCP bridge mode#6254
[DCP Ingestion] Modify the CDC Image Dockerfile and script to support the new DCP bridge mode#6254gmechali wants to merge 1 commit intodatacommonsorg:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the CDC ingestion infrastructure to support a new 'dcpbridge' mode. The changes include necessary environment configurations in the Docker container and updates to the execution script to accommodate the new mode and allow for more flexible command-line argument passing. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the cdc_data Dockerfile to install the Google Cloud SDK and changes the entrypoint to bash. It also modifies run.sh to support the dcpbridge run mode and allows passing extra arguments to the stats processing script. A recommendation was made to use non-interactive flags and clean up the package cache in the Dockerfile to improve build reliability and reduce image size.
| RUN apt-get update && apt-get install -y curl \ | ||
| && curl -sSL https://sdk.cloud.google.com | bash |
There was a problem hiding this comment.
The installation of the Google Cloud SDK should be non-interactive to prevent the build from hanging or failing in automated environments (like CI/CD). Additionally, it is best practice to clean up the apt cache and use --no-install-recommends to keep the Docker image size minimal.
RUN apt-get update && apt-get install -y --no-install-recommends curl \
&& curl -sSL https://sdk.cloud.google.com | bash -s -- --disable-prompts \
&& rm -rf /var/lib/apt/lists/*
| --output_dir=$DC_OUTPUT_DIR \ | ||
| --mode=$DATA_RUN_MODE | ||
| --mode=$DATA_RUN_MODE \ | ||
| "$@" |
There was a problem hiding this comment.
how do we plan on starting the ingestion workflow? Would it make sense to run gcloud command after this line (the stats.main execution) to keep them decoupled?
No description provided.