Download Error Fix : WorldBank_IDS#1987
Open
kartik-s21 wants to merge 2 commits intodatacommonsorg:masterfrom
Open
Download Error Fix : WorldBank_IDS#1987kartik-s21 wants to merge 2 commits intodatacommonsorg:masterfrom
kartik-s21 wants to merge 2 commits intodatacommonsorg:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the robustness of data downloading and processing scripts by implementing CSV-specific filtering and refactoring the World Bank data downloader to process indicators individually, which improves error resilience. Feedback was provided to move the instantiation of the DebtIDS object inside the indicator loop to ensure a fresh state for each attempt and avoid potential issues from failed iterations.
kartik-s21
force-pushed
the
fix-wb-ids-download
branch
from
5323dc1 to
f182fa5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a crash in 'download.py' for the World Bank IDS import. The script was failing when requesting data for future years (current year + 6).
Changes:
Added a try-except block around the data fetching logic to gracefully handle API failures.
Ensured the script continues processing other indicators if one fails.