Modified preprocess.py to remove the strict file count mismatch check.#1986
Open
niveditasing wants to merge 4 commits intodatacommonsorg:masterfrom
Open
Modified preprocess.py to remove the strict file count mismatch check.#1986niveditasing wants to merge 4 commits intodatacommonsorg:masterfrom
niveditasing wants to merge 4 commits intodatacommonsorg:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the file processing logic in the US Census PEP preprocessing script to handle partial successes by logging a warning instead of failing when the number of processed files is less than expected. It also updates the error handling when no files are processed. A review comment suggests reverting the change from logging.fatal to logging.error to ensure the script exits with a non-zero status upon failure, preventing silent failures in automated environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified preprocess.py to remove the strict file count mismatch check.
differ is clean & has no deletions
PR checklist : https://docs.google.com/spreadsheets/d/1BzweR9Sj58j0H2_BweGTmfE4Z1lrjPZL8u1FS0kzCeg/edit?pli=1&gid=0#gid=0