acceptance: replace TestGenerateFromExistingJobAndDeploy#5190
Open
shreyas-goenka wants to merge 3 commits intomainfrom
Open
acceptance: replace TestGenerateFromExistingJobAndDeploy#5190shreyas-goenka wants to merge 3 commits intomainfrom
shreyas-goenka wants to merge 3 commits intomainfrom
Conversation
Covers the same flow as the integration test TestGenerateFromExistingJobAndDeploy (which is removed in this PR): upload notebook → create job → bundle generate job → bundle deploy → bundle destroy. Runs on both Local (testserver) and Cloud. Co-authored-by: Isaac
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
changed the title
Contributor
Approval status: pending
|
With MSYS_NO_PATHCONV=1 set globally in test.toml, Git Bash on Windows stops translating the shebang script's path, so python3.exe can't find add_repl.py / contains.py. Mirror the existing envsubst() pattern in acceptance/script.prepare and unset MSYS_NO_PATHCONV just for those calls. Co-authored-by: Isaac
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
filepath.Rel produced backslashes on Windows, so `bundle generate job` wrote `notebook_path: ..\src\test_notebook.py` into the generated YAML. Apply filepath.ToSlash in markFileForDownload, MarkDirectoryForDownload, and markNotebookForDownload to match the existing pipeline.go pattern and the codebase rule that file paths in user-visible output use forward slashes. Caught by the new python_job_and_deploy acceptance test on Windows. Co-authored-by: Isaac
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
TestGenerateFromExistingJobAndDeployfromintegration/toacceptance/. Acceptance tests are the only path that wires up terraform installs now, so the integration variant can't run end-to-end.The new test runs the same flow (upload notebook → create job →
bundle generate job→bundle deploy→bundle destroy) on both modes:localupdate: ~5scloudupdate(azure-prod-ucws, terraform + direct): ~3-4mAlso fixes a Windows path-separator bug in
bundle/generate/downloader.gothat the new test caught:filepath.Relreturned..\src\test_notebook.pyon Windows, so the generated YAML had OS-native separators. Mirrors the existingfilepath.ToSlashpattern inpipeline.go.This pull request was AI-assisted by Isaac.
We did not have coverage for generate + deploy in our existing tests, that's why I translated it instead.