chore: upgrade lib-node-registry to 0.7.0 for cache busting - #30
Merged
Conversation
0.7.0 extracts a changed artefact into a content-versioned directory, so an updated plugin resolves to a brand-new path and Node's ESM registry reloads the whole module graph (entry + siblings + bundled deps). Removes the now-redundant cacheBust option from importPluginModule: the query-string trick only reloaded the entry module, was strictly worse than the lib's path-based busting, and was never used by any caller. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade
@data-fair/lib-node-registry0.6.0 → 0.7.0 inapiandworker,and remove the now-redundant
cacheBustoption fromimportPluginModule.Why: 0.7.0 extracts a changed artefact into a content-versioned directory,
so an updated plugin resolves to a brand-new absolute path. That forces Node's
ESM registry to reload the whole module graph (entry + siblings + bundled deps)
— something the old
?imported=<ts>query suffix could never do (it onlyreloaded the entry module). The query-string trick was also dead code: no caller
ever passed
cacheBust: true.Regression risks:
importPluginModulelost its secondoptsparameter — a signature change on ashared export. All three callers (api, worker, the 0.11.0 upgrade script) pass
a single argument;
check-typespasses.could serve a stale module after a plugin update now reloads it. Intended, but
the behavior shift is the point of the PR.
.meta.jsondirs are treated ascold and pruned by the lib, so no migration is required.