-
Notifications
You must be signed in to change notification settings - Fork 58
feat(platform-wallet): report the balance a pooled build can actually spend #4582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
romchornyi
wants to merge
9
commits into
v4.2-dev
Choose a base branch
from
feat/pooled-spendable-balance
base: v4.2-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+649
−21
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4538fc4
feat(platform-wallet): let a Core build fund from only the inputs it …
jeanpierreroma d207874
feat(platform-wallet): let a Core build fund from only the inputs it …
jeanpierreroma 28044ee
feat(platform-wallet): report the balance a pooled build can actually…
jeanpierreroma 96c8be1
refactor(platform-wallet): drive both funding paths from one account …
jeanpierreroma c002d33
Merge branch 'v4.2-dev' into feat/pooled-spendable-balance
jeanpierreroma bb3ea98
test(platform-wallet): pin pooled_spendable_balance to the funding set
jeanpierreroma dd92e1b
feat(platform-wallet): price the fee into a pooled send-max figure
jeanpierreroma 6444e67
style: rustfmt the new pooled-max-sendable FFI entry point
jeanpierreroma f95e401
fix(platform-wallet): cap pooled_max_sendable at the standard input l…
jeanpierreroma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same capture here.
The doc block starting at line 629 ("Fund the build from the inputs
core_wallet_tx_builder_add_inputs_from_outpointssupplied, and nothing else" … "fails with a too-many-inputs error") belongs tocore_wallet_tx_builder_use_only_added_inputs, which now sits at line 674 with only the boilerplate# Safetynote.This one leaks further than the Rust-side twin: cbindgen emits these into the generated C header the Swift SDK imports, so the public header will describe a balance getter in terms of batched-drain funding, while
use_only_added_inputs— new in the base PR, and whose entire rationale lived in that block — ships with no explanation at all.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. The stacking had wedged the balance getter between this doc block and the function it documents; it now sits below
core_wallet_tx_builder_use_only_added_inputs, so the block belongs to that function again and the getter has its own.The header point was the one that made this more than cosmetic — cbindgen emits these, so the public header the Swift SDK imports would have described a balance getter in terms of batched-drain funding while the function whose entire rationale lived in that block shipped bare. Resolved as part of the
v4.2-devmerge after #4548 landed (c002d33), which is why it isn't in the later commit.🤖 Generated with Claude Code