Skip to content

making darkroom filmstrip selections more clear #22361

Description

@anoderay

the problem

In darkrooms filmstrip the states hover, opened and selected are very hard to differentiate because they share the same visual styling. Because of this it is impossible to see wheter the opened image is currently selected. In combination with darkroom filmstrip having the quirk of selecting the currently open image in combination with a clicked image this may lead to in unintentionally acting upon the open image.

See also issue #22277 and the discussion in PR #22285.

possible solutions

I created various mockups and would like to invite discussing how the selection.

current state

Image

solid white/black line

Image Image
/* solid white line */
#thumbtable-filmstrip #thumb-main:selected #thumb-image{ border: 2px solid white;}

/* solid black line */
#thumbtable-filmstrip #thumb-main:selected #thumb-image{border: 2px solid black;}

👍 Simple, somewhat in keeping with darktable's design language
👎 hard to see on dark/bright images, not necessarily compatible with the different themes

solid gold line

Image
/* solid gold line */
#thumbtable-filmstrip #thumb-main:selected #thumb-image{border: 2px solid gold;}

👍 not too obtrusive, visible on darker and brighter images compatible with brighter and darker themes
👎 conceptually interferes with the marking of grouped images and not 100% in line with the UIs visual language

dashed or dotted white/black lines

Image Image Image
/* dashed white */
#thumbtable-filmstrip #thumb-main:selected #thumb-image{border: 2px dashed white;}

/* dashed black */
#thumbtable-filmstrip #thumb-main:selected #thumb-image{border: 2px dashed black;}

/* dotted white */
#thumbtable-filmstrip #thumb-main:selected #thumb-image{border: 3px dotted white;}

👍 fairly visible
👎 visually very busy, bright/dark issues like the solid black/white lines

partial line at the bottom

Image
/* 9 partial lower edge */
#thumbtable-filmstrip #thumb-main:selected #thumb-image{
  border-width: 0 0 4px 0;
  border-style: solid;
  border-image: linear-gradient(to right,
      transparent 33%, gold 33%, gold 66%, transparent 66%) 0 0 4 0 / 0 0 4px 0;
}

👍 I find the concept interesting
👎 but it is too bulky

white line + shadow

Image

👍 simple, visible on bright and dark images
👎 darktables UI doesn't use shading in other places, probably requires more changes then css - at least I didn't get the css shadows to render.

white line + corner marking + shadow

lower right
Image
Image

upper right
Image
Image

(gimp mockups)

👍 very visible, works with brighter and darker images and themes
👍 when adding numbers functional benefit, would especially also make it clear that the active image is (almost) always selected
❓ requires more thought - maybe the number should only be displayed when the thumbnails are sized for "more details"
👎 as far as I know not possible with css theming, requires more code changes.

final thoughts

I am currently using the solid gold line and it works well for me. Together with the corner markings that one would be my favourite. It would be easy to implement and is nicely visible. I am not much of an image-grouper though and cannot judge how annoying it is in combination with image-groupings.

@wpferguson @hats-np @lefth

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions