Fix critical onboarding and Homebrew regressions - #652
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
CLI providers intentionally allow empty model values for defaults, so onboarding readiness must not require a model for those providers. Homebrew adoption was also double-quoting the nix-darwin host attr, forcing eval fallback and risking duplicate managed Homebrew entries. Co-authored-by: cooper <czxtm@users.noreply.github.com>
Recent provider refactoring left a missing onboarding provider type and an unused CLI table, causing tsc to fail before Vite could build. Co-authored-by: cooper <czxtm@users.noreply.github.com>
Scott McMaster (scottmcmaster)
approved these changes
Aug 10, 2026
Scott McMaster (scottmcmaster)
requested changes
Aug 11, 2026
Scott McMaster (scottmcmaster)
left a comment
Scott McMaster (scottmcmaster)
left a comment
Collaborator
There was a problem hiding this comment.
At least for the homebrew_adopt.rs change, I believe this PR is obsolete.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
bun run buildbun run test:unit -- src/lib/providers/ai-provider-validation.test.ts src/components/widget/onboarding/inference/inference-setup.test.tsxcargo +stable test --manifest-path apps/native/src-tauri/Cargo.toml homebrew_adoptDocs