Repository navigation
rsa: reject secret keys whose primes are not 1024 bits - #30
Merged
Merged
Conversation
The raw encoding holds each prime in 128 bytes, but DER import accepted any 2048-bit key. Marshal then panicked on a 1025-bit first prime, or overwrote the first prime's field with a 1025-bit second one. DER import now requires two 1024-bit primes. New tests also pin the raw rejection of repeated primes and oversized private exponents, with the same test vectors as the Rust fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The raw encoding holds each prime in 128 bytes, but DER import accepted any 2048-bit key. Marshal then panicked on a 1025-bit first prime, or overwrote the first prime's field with a 1025-bit second one. DER import now requires two 1024-bit primes. New tests also pin the raw rejection of repeated primes and oversized private exponents, with the same test vectors as the Rust fix.