Skip to content

docs: document Amplifier-side MCP prerequisites in port plan#508

Merged
danshapiro merged 1 commit into
mainfrom
docs/amplifier-mcp-prereqs
Jul 7, 2026
Merged

docs: document Amplifier-side MCP prerequisites in port plan#508
danshapiro merged 1 commit into
mainfrom
docs/amplifier-mcp-prereqs

Conversation

@danshapiro

Copy link
Copy Markdown
Owner

What changed

Rewrote the "MCP — KNOWN LIMITATION" section of docs/port-plan.md as "MCP — Amplifier-side prerequisites". Single-file docs change.

Why

The MCP injection was failing silently. There are two Amplifier-side prerequisites, not one:

  1. tool-mcp must be mounted in the user's bundle (~/.amplifier/settings.yaml modules.tools entry, or app bundle).
  2. The mcp Python SDK must be installed in Amplifier's venv — tool-mcp imports it at mount time, and Amplifier swallows mount failures as silent warnings, which looks identical to "no servers configured". Durable fix: uv tool install "git+https://github.com/microsoft/amplifier@main" --with "mcp>=1.0.0" --force.

Also corrects the discovery-chain description: config sources are merged (inline > env > project > user), not a fallback chain — so ~/.amplifier/mcp.json must stay nonexistent to preserve the "no MCPs outside freshell" property.

How to verify

Docs-only. Verified end-to-end on the dev machine 2026-07-06: env var injected → tool-mcp reports servers seen: ['freshell'] → session tool roster includes mcp_freshell_freshell.

Breaking changes

None.

Generated with Amplifier

Co-Authored-By: Amplifier 240397093+microsoft-amplifier@users.noreply.github.com

The MCP injection was failing silently: besides tool-mcp needing to be
mounted in the user's bundle, the mcp Python SDK must be installed in
Amplifier's venv. Mount failures are swallowed as warnings, which looks
identical to 'no servers configured'. Also correct the discovery-chain
description: config sources are merged, not a fallback chain.

Verified end-to-end 2026-07-06: freshell-spawned Amplifier session
mounts mcp_freshell_freshell.

Generated with Amplifier

Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
@danshapiro danshapiro merged commit b59e7d8 into main Jul 7, 2026
1 check passed
@danshapiro danshapiro deleted the docs/amplifier-mcp-prereqs branch July 7, 2026 04:29

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cfc6da9e4a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/port-plan.md
Comment on lines +81 to +86
```yaml
modules:
tools:
- module: tool-mcp
source: git+https://github.com/microsoft/amplifier-module-tool-mcp@main
```

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use a recognized Amplifier config shape for tool-mcp

When users follow this ~/.amplifier/settings.yaml snippet to satisfy the documented prerequisite, Amplifier will not mount tool-mcp: the Microsoft module-resolution spec documents settings.yaml module source overrides under sources: <module-id>: <source-uri-or-object>, while tools: entries are bundle/frontmatter config, not a modules.tools settings key. The supported user-level path in the tool-mcp README is the amplifier bundle add ... --app command already mentioned below, so keeping this snippet makes the MCP setup look complete while Freshell still gets no MCP tools.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants