fix(frontend): bannerUrl が空の場合に /about ページで /null へのアクセスが発生する問題を修正#1
Open
danominium wants to merge 1 commit into
Open
fix(frontend): bannerUrl が空の場合に /about ページで /null へのアクセスが発生する問題を修正#1danominium wants to merge 1 commit into
danominium wants to merge 1 commit into
Conversation
bannerUrl が空の場合は 背景画像を設定しない。
about.overview.vue の background-image: url("null"); によって /null へのリクエストが発生してしまうため。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
/aboutページでbannerUrlが空の場合は 背景画像を設定しない。Why
about.overview.vueのbackground-image: url("null");によって/nullへのアクセスが発生してしまうため。Additional info (optional)
Checklist