handle canonicalize failure in containerized environments#574
Open
venkatesh6114 wants to merge 2 commits intodaisy:mainfrom
Open
handle canonicalize failure in containerized environments#574venkatesh6114 wants to merge 2 commits intodaisy:mainfrom
venkatesh6114 wants to merge 2 commits intodaisy:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #516
path.canonicalize() can fail with ACCESS_DENIED in containerized or sandboxed environments. This caused MathCAT to
bail out entirely when loading rules or reading files.
Changes
absolute) or prepending cwd (if relative).
the original path, letting read_to_string attempt the read anyway.