Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Sorry I cannot accept patches generated or co-authored with generative AI. I'll update the PR guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101.
Two checks in the text paths of
clip_osx.mm:get_data: return false when[string UTF8String]is NULL instead of passing it tomemcpy.stringis nil when the pasteboard no longer holds text by the timestringForType:runs, andreqsizeis still 1 then (0 + 1);UTF8Stringis also declared nullable.set_data: return false when the bytes are not valid UTF-8.initWithBytesNoCopy:length:encoding:returns nil then, andsetString:nil forType:still returns YES, soset_textreported success without copying anything.Builds in Codeware's macOS port (Apple clang, arm64). Both nil cases were checked with a small program against a private pasteboard (
pasteboardWithUniqueName) on macOS 26.5.I agree that my contributions are licensed under the MIT License.
You can find a copy of this license at https://opensource.org/licenses/MIT
🤖 Generated with Claude Code