Use daachorse v5.0.0 and support abi3-py310 - #28
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Rust/Python binding to use daachorse v5.0.0 and updates packaging/CI to build and test abi3-py310 wheels (Python ≥3.10), reducing the need to build per-Python-version wheels.
Changes:
- Upgrade core dependencies (
daachorse5.0.0,pyo30.29.2) and enableabi3-py310. - Extend the Python-exposed constructors to accept
corpusanduse_prefilterfor builder configuration. - Restructure CI to build wheels once per OS and test them across multiple Python versions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/lib.rs |
Adds corpus / use_prefilter constructor options and wires them into the v5 builders. |
tests/test_bytewise.py |
Formatting-only change (extra blank line). |
requirements-dev.txt |
Updates dev-tool minimum versions (pytest, mypy). |
pyproject.toml |
Bumps Python package version to 0.5.0 and sets requires-python >= 3.10. |
Cargo.toml |
Bumps crate version to 0.5.0; upgrades daachorse/pyo3 and enables abi3-py310. |
.github/workflows/CI.yml |
Splits wheel build and test jobs; tests built wheels across Python 3.10–3.14. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vbkaisetsu
marked this pull request as ready for review
August 11, 2026 13:15
vbkaisetsu
enabled auto-merge (squash)
August 11, 2026 13:15
vbkaisetsu
disabled auto-merge
August 11, 2026 13:32
vbkaisetsu
enabled auto-merge (squash)
August 11, 2026 13:38
Member
|
I was talking to my AI agent about this PR, and it accidentally submitted a review on its own. Sorry about that, please ignore it. |
kampersanda
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.