Make VisualizerNode styling props transient#395
Merged
Conversation
NodeG's cursor styling read a non-transient job prop and NodeContents read isInvalidLinkTarget directly; styled-components v6 forwards both to the underlying <g>/<div>. Both are now $-prefixed transient props, matching the rest of this migration.
This was referenced Jun 12, 2026
cigamit
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Follow-up to #380, which merged just before its last review fix was pushed — this recovers that commit.
NodeG's cursor styling read a non-transientjobprop andNodeContentsreadisInvalidLinkTargetdirectly; under styled-components 6 (now on main) both are forwarded to the underlying<g>/<div>DOM elements. Both props are now $-prefixed transient props, matching the rest of the migration, so nothing custom reaches the DOM.Addresses the two Copilot review comments on #380 (made there after merge, recorded in the PR thread).
ISSUE TYPE
COMPONENT NAME
ASCENDER VERSION
ADDITIONAL INFORMATION
Independent of the four open PRs (#385, #390, #392, #393) — verified via
git merge-tree.