Repository navigation
Add a PHPStan check for PHP 8.4 and 8.5 - #490
Merged
Merged
Conversation
Fix the PHP 8 issues the check found so new problems fail without a baseline. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?>, string-to-number arithmetic, a float used as an array index, and an array compared with>=. The result is clean, so there is no baseline.config-dist.phptoconfig.phpinside the job. It does not start a web server or change the local Tsugi install.Test plan
composer phpstanlocally against the existingtsugi/checkout reports no errorsMade with Cursor