Skip to content

fix TestCryptoObfuscationDefaultPoolSize#4565

Merged
buixor merged 1 commit into
masterfrom
fix-bot-detect-tests
Jul 17, 2026
Merged

fix TestCryptoObfuscationDefaultPoolSize#4565
buixor merged 1 commit into
masterfrom
fix-bot-detect-tests

Conversation

@buixor

@buixor buixor commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings July 17, 2026 09:04
@github-actions

Copy link
Copy Markdown

@buixor: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions

Copy link
Copy Markdown

@buixor: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a flaky unit test in the appsec challenge “dynamic module” obfuscation pool logic by avoiding reliance on the wall-clock epoch during runtime construction (which can cross a rotation boundary while obfuscation runs).

Changes:

  • Update TestCryptoObfuscationDefaultPoolSize to assert against the contents of dynamicModuleCache rather than re-reading the current epoch from the keyring/clock.
  • Ensure the cache lock is held safely across inspection via defer while validating cached epochs all contain exactly one variant.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@buixor

buixor commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

/kind chore
/area appsec

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.77%. Comparing base (66ab61f) to head (432a1a5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4565      +/-   ##
==========================================
+ Coverage   63.76%   63.77%   +0.01%     
==========================================
  Files         507      507              
  Lines       38652    38652              
==========================================
+ Hits        24645    24649       +4     
+ Misses      11657    11648       -9     
- Partials     2350     2355       +5     
Flag Coverage Δ
bats 41.66% <ø> (+<0.01%) ⬆️
unit-linux 40.11% <ø> (-0.01%) ⬇️
unit-windows 28.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@buixor
buixor merged commit 0a79ef8 into master Jul 17, 2026
16 of 19 checks passed
@buixor
buixor deleted the fix-bot-detect-tests branch July 17, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants