fix TestCryptoObfuscationDefaultPoolSize#4565
Conversation
|
@buixor: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@buixor: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
There was a problem hiding this comment.
Pull request overview
This pull request fixes a flaky unit test in the appsec challenge “dynamic module” obfuscation pool logic by avoiding reliance on the wall-clock epoch during runtime construction (which can cross a rotation boundary while obfuscation runs).
Changes:
- Update
TestCryptoObfuscationDefaultPoolSizeto assert against the contents ofdynamicModuleCacherather than re-reading the current epoch from the keyring/clock. - Ensure the cache lock is held safely across inspection via
deferwhile validating cached epochs all contain exactly one variant.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/kind chore |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4565 +/- ##
==========================================
+ Coverage 63.76% 63.77% +0.01%
==========================================
Files 507 507
Lines 38652 38652
==========================================
+ Hits 24645 24649 +4
+ Misses 11657 11648 -9
- Partials 2350 2355 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No description provided.