[agent] Browse song radio without interrupting playback by alexng353 · Pull Request #359 · crmne/spotifast

alexng353 · 2026-09-08T07:50:59Z

[agent] Browse song radio without interrupting playback

Go to song radio opens a station page; Start song radio starts playback and opens Queue. The page keeps the seed song and artwork visible while loading and offers play and refresh controls.
Resolves stations and metadata through librespot’s existing typed context resolver. Browsing does not activate Connect, replace the queue, create playlists, or write listening history. The station may differ from Spotify’s own radio playlist.
Linux validation: formatter, Clippy with and without all features, both all-target test suites, doc tests, Rust docs, launcher tests, issue-assessment tests, and Jekyll. Demo screenshots and UI tests cover layout and actions; authenticated Spotify resolution and other platforms were not exercised in this revision.

Theme / size	Before: playlist	After: radio page
dark, 1240x800
dark, 760x800
light, 1240x800
light, 760x800

Co-Authored-By: GPT-6 (OpenAI) noreply@openai.com

alexng353 · 2026-09-11T08:35:58Z

Ok so update, I had codex decompile the spotify desktop app, then pull the precise way spotify "generates" the radio playlists, which is with the api endpoint /inspiredby-mix/v2/seed_to_playlist/{seed_uri}?response-format=json

I have no idea how maintainers want to move forward with this changset. I also have another change that makes the radio pages just render with librespot's built in radio API, but that generates different radios to the actual spotify internal ones (I think)

Please let me know what to do

--- More context ---

Librespot's station API hits GET https://<resolved-spclient-host>/context-resolve/v1/spotify:station:track:<song-id>, which returns real spotify radio data, but does not create a playlist on the user account like real spotify does.

I don't know if this behaviour is desirable or not (creating playlists on the user account), but for personal use I've built this so that it matches the behaviour I like.

I can also make it a settings toggle if that's desired. I've also got a local changeset that bypasses librespot's thing where they don't want to writeback recently played songs/playlists to spotify, which I'm using, and can upstream if that's wanted.

crmne

The visible scope, browsing song radio separately from starting playback, fits. Please use your version backed by librespot’s existing typed context resolver. We can accept the station it provides without matching Spotify’s private radio playlist exactly.

Remove the inspiredby-mix endpoint and keep playlist creation and listening-history writeback out of this PR. Rebase that scoped version onto main and add the required tests and visual evidence.

alexng353 · 2026-09-15T04:43:10Z

The visible scope, browsing song radio separately from starting playback, fits. Please use your version backed by librespot’s existing typed context resolver. We can accept the station it provides without matching Spotify’s private radio playlist exactly.

Remove the inspiredby-mix endpoint and keep playlist creation and listening-history writeback out of this PR. Rebase that scoped version onto main and add the required tests and visual evidence.

Np. Just a question, does using the internal api break spotify tos lol
I didn't read it

Also, those other changes were not meant to be in this PR, that's my fault. Thanks for the comments.

Separate radio-page navigation from immediate station playback. Preserve loading metadata, ignore stale responses, and retry restored pages when the local playback session becomes ready. Keep private playlist creation and listening-history reporting outside this change. Include regression tests and isolated light/dark before-and-after captures. Co-Authored-By: GPT-6 (OpenAI) <noreply@openai.com>

crmne

Visible scope remains the previously accepted split between browsing a radio page and starting radio playback. The current code uses the requested librespot resolver approach, and CI passes.

Please turn the screenshot pairs into the required HTML comparison, with theme/size selectors and Before/After controls, and include loading, error/retry and empty states. The existing scope decision stands; final visual review and authenticated station-resolution validation remain outstanding.

Copilot

Copilot review overview

🟡 Changes recommended

Unresolved navigation, caching, API-contract, restoration, and track-validity issues remain, and visual-review evidence is incomplete.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 4 · 1

Open (5)

Radio pages are never evicted, causing unbounded memory growth · New
Opening radio from fullscreen lyrics does not exit fullscreen · New
Radio browsing consumes shared Web API quota · New
Radio actions are available for unsupported tracks · New
Missing required visual review evidence for radio page · New

What changed in this PR

Adds a browsable song-radio page with librespot resolution, playback controls, queue integration, tests, demos, and documentation.

Changes:

Adds radio navigation and track-menu actions.
Implements asynchronous station loading and metadata.
Adds radio UI, caching, artwork handling, and playback.
Updates documentation and visual evidence.

File	Summary
`src/ui/widgets.rs`	Adds song-radio menu actions.
`src/ui/radio.rs`	Renders the radio page and controls.
`src/ui/mod.rs`	Registers radio routing and tinting.
`src/ui/collection.rs`	Preserves sorted radio playback order.
`src/radio.rs`	Resolves stations and metadata.
`src/player.rs`	Exposes radio resolution.
`src/model.rs`	Adds radio pages and actions.
`src/lib.rs`	Exports the radio module.
`src/images.rs`	Adds artwork readiness checks.
`src/demo.rs`	Adds demo radio data and tests.
`src/backend.rs`	Loads radio stations asynchronously.
`src/app/radio.rs`	Manages radio state and navigation.
`src/app.rs`	Integrates radio events, playback, and caching.
`README.md`	Documents song radio.
`docs/assets/song-radio/README.md`	Provides screenshot evidence.
`docs/_reference/queue.md`	Updates queue behavior documentation.
`docs/_reference/how-it-connects.md`	Documents radio architecture.
`docs/_guide/using-spotifast.md`	Adds user guidance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

    pub playlist_pages: HashMap<String, PlaylistPage>,
    load_generation: u64,
    pub album_pages: HashMap<String, AlbumPage>,
+    pub radio_pages: HashMap<String, crate::radio::RadioPage>,


        }
        match action {
            Action::Open(page) => self.open(page),
+            Action::OpenRadio(track) => self.open_radio(*track),


+                        self.track_cache.insert(id.clone(), track);
+                    }
+                }
+                self.request_contains(uris);


            if menu_item(ui, &palette, Some(Icon::Radio), "Go to song radio") {
+                app.actions.push(Action::OpenRadio(Box::new(track.clone())));
+            }
+            if menu_item(ui, &palette, Some(Icon::Play), "Start song radio") {
                app.actions.push(Action::PlayTrackRadio(uri.clone()));
            }


+| Theme and size | Before | After |
+| --- | --- | --- |
+| Dark, 1240x800 | ![](before-dark-1240x800.png) | ![](after-dark-1240x800.png) |
+| Light, 1240x800 | ![](before-light-1240x800.png) | ![](after-light-1240x800.png) |
+| Dark, 760x800 | ![](before-dark-760x800.png) | ![](after-dark-760x800.png) |
+| Light, 760x800 | ![](before-light-760x800.png) | ![](after-light-760x800.png) |


fedalc mentioned this pull request Sep 9, 2026

"go to song radio" starts song without opening the radio #369

Open

alexng353 marked this pull request as draft September 11, 2026 08:33

alexng353 marked this pull request as ready for review September 11, 2026 08:36

crmne requested changes Sep 12, 2026

View reviewed changes

alexng353 force-pushed the codex/song-radio-browsing branch from 0e57e87 to 81ac67e Compare September 15, 2026 04:59

alexng353 changed the title ~~Browse song radio without interrupting playback~~ [agent] Browse song radio without interrupting playback Sep 15, 2026

crmne requested changes Sep 20, 2026

View reviewed changes

crmne requested a lite review from Copilot September 20, 2026 16:18

Copilot started reviewing on behalf of crmne September 20, 2026 16:18 View session

Copilot AI reviewed Sep 20, 2026

View reviewed changes

Navigation Menu

Uh oh!

[agent] Browse song radio without interrupting playback - #359

[agent] Browse song radio without interrupting playback#359
alexng353 wants to merge 1 commit into
crmne:mainfrom
alexng353:codex/song-radio-browsing

alexng353 commented Sep 8, 2026 •

edited

Loading

Uh oh!

alexng353 commented Sep 11, 2026 •

edited

Loading

Uh oh!

crmne left a comment

Uh oh!

alexng353 commented Sep 15, 2026

Uh oh!

crmne left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

alexng353 commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexng353 commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crmne left a comment

Choose a reason for hiding this comment

Uh oh!

alexng353 commented Sep 15, 2026

Uh oh!

crmne left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alexng353 commented Sep 8, 2026 •

edited

Loading

alexng353 commented Sep 11, 2026 •

edited

Loading