Refactor devices#44
Merged
Merged
Conversation
Member
Author
|
Waiting for creatorsim/creator-assembler#8 to merge so I can update the |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
rajayonin
force-pushed
the
refactor-devices
branch
from
July 10, 2026 17:10
2271392 to
265b5f9
Compare
- Refactored devices script into a single DeviceManager class - Device configuration is now done in the architecture file - ability to enable/disable devices (unused) Closes creatorsim#14
rajayonin
force-pushed
the
refactor-devices
branch
from
July 10, 2026 17:49
265b5f9 to
aa1b2e7
Compare
rajayonin
marked this pull request as ready for review
July 10, 2026 17:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devices are now defined in each architecture's config file, instead of having hard-coded addresses. The user basically selects from a predefined set of device classes and sets them up as desired.
Will update docs on the wiki.
Closes #14.