Skip to content

feat(replace): allow glob pattern in Replace::file - #1020

Open
FreeMasen wants to merge 1 commit into
crate-ci:mainfrom
FreeMasen:feat/globs-for-file-replace
Open

FreeMasen wants to merge 1 commit into
crate-ci:mainfrom
FreeMasen:feat/globs-for-file-replace

Conversation

@FreeMasen

Copy link
Copy Markdown

What does this PR try to solve?

Closes #104

Notes to reviewers

In an attempt to address glob patterns in the pre-release-replace configuration this uses the deserializer implementation for that field to convert the input into Vec<PathBuf> via the globwalk crate.

LLM involvement: none

@epage

epage commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Couple of quick notes:

  • globwalk seems like a dead end crate to use at this point
  • we shouldn't be walking the filesystem at config parse time
  • if we have a custom deserializer, I'd prefer to use serde_untagged
  • docs would need updating
  • if we could have a test, that would be a good, see also https://epage.github.io/dev/pr-style/#c-test

@FreeMasen

Copy link
Copy Markdown
Author

Couple of quick notes:

* `globwalk` seems like a dead end crate to use at this point

* we shouldn't be walking the filesystem at config parse time

* if we have a custom deserializer, I'd prefer to use `serde_untagged`

* docs would need updating

* if we could have a test, that would be a good, see also https://epage.github.io/dev/pr-style/#c-test

Thanks for the review and feedback, I'll try and take another pass at this soon

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow replacements to apply to multiple files

2 participants