fix: prod deploy#91
Merged
limitofzero merged 2 commits intomainfrom May 6, 2026
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Danziger
approved these changes
May 5, 2026
kernelwhisperer
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The prebuild:strapi script ran strapi ts:generate-types on every build. That command boots a full Strapi instance (Strapi(...).register()) to walk all content types, which triggers every plugin's register() lifecycle — including @strapi/plugin-upload's provider initialization.
So the previous flow only worked when the cloud provider wasn't injected AND the build had a chance to regenerate types — neither pipeline satisfied both.
I've just run yarn gen:strapi-types and commit the result whenever and commit the result, it works fine for current image build but to test it on strapi cloud - need to merge and deploy it