Validations are buggy

[tapajos]

Issue from: http://github.com/couchrest/couchrest/issues#issue/28

Code:

class Crap < CouchRest::ExtendedDocument
  include CouchRest::Validation
  use_database CouchDB.default_database

  property :fail

  before_save :check_something

  private
    def check_something
      self.errors.add(:fail, "You're bastard")
    end
end

Output from console:

> crap = Crap.new
> => {"couchrest-type"=>"Crap"}
> 
> > crap.fail = 'something'
> > => "something"
> > crap.valid?
> > => true
> > crap.save
> > => true
> > crap.errors
> > => #["You're bastard"]}>
> > crap.valid?
> > => true
> 
> 

[tapajos]

The problem is that add a message to self.errors is not enough to valid?
return false. You need to implement a custom validate or we need to change
couchrest to check self.errors too.

I'm not sure about what's the best choice.

[deepj]

I think it should be changed in CouchRest. This way more closed to ActiveRecord behaviour (I hope I'm not wrong I haven't worked with AR a long time :)) and is more logical from my point of view. Custom validation is too complicated way. It's just my opinion.

[tapajos]

Deepj,

I think that you are right about ActiveRecord. We will work on it.