Implement a standalone datasource gateway#37
Draft
sudosalim wants to merge 19 commits into
Draft
Conversation
Co-authored-by: <mara.tarhon@couchbase.com>
Co-authored-by: <mara.tarhon@couchbase.com>
Use prometheus query engine to run promql functions, only selectors generate slq++
m-tarhon
reviewed
Jun 4, 2026
| } | ||
|
|
||
| return strings.Join(conditions, " AND ") | ||
| } |
Contributor
There was a problem hiding this comment.
A lot of this code is also present in cbmonitor/pkg/querybuilder. Is there any way to centralise this code? Do we even need the pkg folder anymore when this PR gets merged?
m-tarhon
reviewed
Jun 4, 2026
| default: | ||
| return StoreCouchbase | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I could just be understanding it wrong, but why is the default StoreCouchbase?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial implementation to the standalone datasource. This routes per snapshot to a different datasource.
It moved the promql logic from the Grafana app and outside grafana all together. This way Grafana dashboards, tools and cbmonitor talk to a single datasource irregardless of the metrics storage.
The gateway is the generalisation of the https://github.com/m-tarhon/SyncedApp implementation.