Skip to content

fix: respect max_gas_wanted for mempool#595

Draft
mmsqe wants to merge 3 commits into
cosmos:mainfrom
mmsqe:clean_gas_wanted
Draft

fix: respect max_gas_wanted for mempool#595
mmsqe wants to merge 3 commits into
cosmos:mainfrom
mmsqe:clean_gas_wanted

Conversation

@mmsqe

@mmsqe mmsqe commented Sep 10, 2025

Copy link
Copy Markdown
Collaborator

Description

Closes: #593


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@Hellobloc

Copy link
Copy Markdown

Nice job!

@mmsqe

mmsqe commented Sep 10, 2025

Copy link
Copy Markdown
Collaborator Author

Nice job!

acutally backport sdk seems a breaking change, maybe we could just clean up here and keep max-tx-gas-wanted as 0

@mmsqe mmsqe changed the title chore: cleanup unused cumulative gasWanted fix: respect max_gas_wanted for mempool Sep 11, 2025
@mmsqe mmsqe marked this pull request as ready for review September 11, 2025 01:49
@mmsqe mmsqe requested review from a team as code owners September 11, 2025 01:49
@vladjdk vladjdk self-assigned this Sep 15, 2025
@vladjdk

vladjdk commented Sep 17, 2025

Copy link
Copy Markdown
Member

While we wait for the SDK change to be reviewed, could you fix the go.mod merge conflicts?

@github-actions

github-actions Bot commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

@github-actions github-actions Bot closed this Nov 11, 2025
@mmsqe mmsqe reopened this May 26, 2026
@mmsqe mmsqe requested a review from a team as a code owner May 26, 2026 16:05
@greptile-apps

greptile-apps Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

PR author is not in the allowed authors list.

@mmsqe mmsqe force-pushed the clean_gas_wanted branch from d28294b to f06cdec Compare May 26, 2026 16:06
@codecov

codecov Bot commented May 26, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@aljo242 aljo242 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocked on the cosmos-sdk replace directive: both go.mod files replace cosmos/cosmos-sdk with github.com/mmsqe/cosmos-sdk v0.46.0-beta2.0.20260526155725-0c80f02aefb0. needs cosmos/cosmos-sdk#25338 to land upstream before the replace can be dropped and this merged. the fix itself looks correct.

@mmsqe mmsqe marked this pull request as draft May 29, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad Maxtx-gas-want implementation that may lead to proposal rejection of normal nodes.

4 participants