fix(vm): remove nonexistent vesting static precompile#1193
Open
nowooj wants to merge 3 commits into
Open
Conversation
Contributor
|
PR author is not in the allowed authors list. |
Contributor
|
this is the right pr to merge over #1196 (more complete, covers genesis scripts too). one concern before merge: no param migration. any chain initialized with default params already has |
aljo242
requested changes
May 26, 2026
aljo242
left a comment
Contributor
There was a problem hiding this comment.
needs param migration for existing chains that already have the vesting precompile address in state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the nonexistent vesting static precompile address from the default active static precompile list.
The vesting precompile address was listed in
AvailableStaticPrecompiles, but there is noprecompiles/vestingimplementation and no corresponding static precompile registration inDefaultStaticPrecompiles. This could make0x0000000000000000000000000000000000000803active in params without a registered implementation.Closes: #1192
Author Checklist
I have...
mainbranchReview instructions:
0x0000000000000000000000000000000000000803is no longer included in default/manual active static precompile lists.go test -tags=test ./x/vm/types ./x/vm/keeper.